Custom roles and capabilities media not work right

Question

Help with new user wordpress capabilities and roles custom. The media not work upload and display images in galery.

image error: https://i.sstatic.net/VE59k.png

code:

if ( get_role('user_products') ) {
    remove_role('user_products');
}

add_action('init','add_my_custom_role');
function add_my_custom_role() {

    add_role( 
      'user_products', 
      __( 'User Products', 'editproducts' ), 
      array(
               'read'            => true,
               'create_posts'      => true,
               'edit_posts'        => true,
               'edit_others_posts' => true,
               'delete_posts' => true,
               'upload_files' => true,
               'upload_medias' => true,                   
               'edit_files' => true,
               'publish_posts' => true,
               'manage_categories' => true,
               'edit_comment' => true,
               'edit_products' => true,
               'edit_others_products' => true,
               'publish_products' => true,
               'delete_products' => true,
               'read_private_products' => true,
               'delete_private_products' => true,
               'edit_private_products' => true,
               'edit_published_products' => true,
               'delete_others_pages' => true,
               'delete_others_posts' => true,
               'delete_pages' => true,
               'delete_private_pages' => true,
               'delete_private_posts' => true,
               'delete_published_pages' => true,
               'delete_published_posts' => true,
               'edit_others_pages' => true,
               'edit_pages' => true,
               'edit_private_pages' => true,
               'edit_private_posts' => true,
               'edit_published_pages' => true,
               'edit_published_posts' => true,
               'manage_links' => true,
               'moderate_comments' => true,
               'publish_pages' => true,
               'read_private_pages' => true,
               'read_private_posts' => true,
               'unfiltered_html' => false,
               'level_3' => true,                   
              // 'edit_attachments' => true,
              // 'delete_attachments' => true,
              // 'read_others_attachments' => true,
              // 'edit_others_attachments' => true,
              // 'delete_others_attachments' => true,

        // Various Capabilities
    ));
}

Code update, i have the same error:

add_action('init','add_my_custom_role');
function add_my_custom_role() {

    add_role( 
      'user_products', 
      __( 'User Products', 'editproducts' ), 
      array(
               'read'            => true,
               'create_posts'      => true,
               'edit_posts'        => true,
               'edit_others_posts' => true,
               'delete_posts' => true,
               'upload_files' => true,
               'upload_medias' => true,                   
               'edit_files' => true,
               'publish_posts' => true,
               'manage_categories' => true,
               'edit_comment' => true,
               'edit_products' => true,
               'edit_others_products' => true,
               'publish_products' => true,
               'delete_products' => true,
               'read_private_products' => true,
               'delete_private_products' => true,
               'edit_private_products' => true,
               'edit_published_products' => true,
               'delete_others_pages' => true,
               'delete_others_posts' => true,
               'delete_pages' => true,
               'delete_private_pages' => true,
               'delete_private_posts' => true,
               'delete_published_pages' => true,
               'delete_published_posts' => true,
               'edit_others_pages' => true,
               'edit_pages' => true,
               'edit_private_pages' => true,
               'edit_private_posts' => true,
               'edit_published_pages' => true,
               'edit_published_posts' => true,
               'manage_links' => true,
               'moderate_comments' => true,
               'publish_pages' => true,
               'read_private_pages' => true,
               'read_private_posts' => true,
               'unfiltered_html' => false,
               'level_3' => true,                   
              // 'edit_attachments' => true,
              // 'delete_attachments' => true,
              // 'read_others_attachments' => true,
              // 'edit_others_attachments' => true,
              // 'delete_others_attachments' => true,

        // Various Capabilities
    ));
}

Answer 1

This happens because on every page load you call remove_role

As the docs note:

When a role is removed, the users who have this role lose all rights on the site.

Roles are not like post types, they exist in the database, and removing/adding a role updates the database. For that reason you shouldn't add them on every page load, it's better to do it on theme activation or plugin activation