0

I'm simply trying to call one (update post description) if the other signals out of stock. They both work perfectly independently:

function single_product_short_description( $post_excerpt ){
    global $product;

    $product_id = method_exists( $product, 'get_id' ) ? $product->get_id() : $product->id;

    if ( is_single( $product_id ) )
      $post_excerpt = '<p class="some-class">' . __( "Out of stock short desc here", "woocommerce" ) . '</p>';

    return $post_excerpt;
}

function custom_get_availability( $availability, $_product ) {
  global $product, $bar, $progress;
  $stock = $product->get_total_stock();
  $progress = 100-$stock;   
  $bar = do_shortcode('[wp_progress_bar text="Tickets Sold - " pc='.$progress.']');

  if ( $_product->is_in_stock() ) {
    $availability['availability'] = __($bar, 'woocommerce');
  }
  if ( !$_product->is_in_stock() ) {
    add_filter( 'woocommerce_short_description', 'single_product_short_description', 10, 1 );
  }
  return $availability;
}

add_filter( 'woocommerce_get_availability', 'custom_get_availability', 1, 2);

What am I doing wrong?

1
  • I would guess that the call to woocommerce_short_description you're trying to hook into has already happened when you add that hook in woocommerce_get_availability.
    – mrben522
    Mar 24, 2019 at 19:26

1 Answer 1

0

I would use do_action instead of add_filter. While similar, you are hooking into an action verse filtering a function. close, but different.

 function custom_get_availability( $availability, $_product ) {
   global $product, $bar, $progress;
   $stock = $product->get_total_stock();
   $progress = 100-$stock;   
   $bar = do_shortcode('[wp_progress_bar text="Tickets Sold - " pc='.$progress.']');

   if ( $_product->is_in_stock() ) {
     $availability['availability'] = __($bar, 'woocommerce');
   }
   if ( !$_product->is_in_stock() ) {
     do_action( 'woocommerce_short_description', single_product_short_description' );
   }
   return $availability;
   }



 function single_product_short_description( $post_excerpt )
  {
     global $product;
     remove_action( 'woocommerce_short_description', single_product_short_description' );


     $product_id = method_exists( $product, 'get_id' ) ? $product->get_id() : $product->id;

     if ( is_single( $product_id ) )
        $post_excerpt = '<p class="some-class">' . __( "Out of stock short desc here", "woocommerce" ) . '</p>';


return $post_excerpt;
 }

Good article on the subject: https://wpsmith.net/2011/the-difference-between-do_action-add_action-and-add_filter/

1
  • No dice unfortunately. Mar 25, 2019 at 20:00

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.