Loop returns the current page's permalink and guid instead of the post in the loop

Question

Here is my code:

global $post;
$args = array(
    'posts_per_page'   => -1,
    'post_type'        => 'post',
);
$the_query = new WP_Query( $args );
$array = get_object_vars($the_query); //convert the object into an array (manual workaround)
if ( $the_query->have_posts() ) :
    $count = 0; //start an iteration count
    while ( $the_query->have_posts() ) : ?>
       <? $the_query->the_post(); ?>
       <?php $postarray = get_object_vars($array['posts'][$count]); 
    //convert the post object into an array
  ?> 
        <div class="row">
            <div class="col-md-6">
                <div class="card">
                    <h4><?php echo get_the_title(); ?></h4>
                    <p><?php echo get_the_excerpt(); ?></p>
                    <?php the_permalink() ?>
                <!-- the guid is now accessable -->
                    <a href="<?php echo $postarray['guid']; ?>">Read More</a>
                </div>
            </div>
        </div>
    <?  endwhile;
else :
    echo wpautop( 'Sorry, no posts were found' );
endif;

I have referenced other questions about this, however my global $post; IS outside the loop (as referenced from Post Loop not Returning Permalink) and I have also already tried using the range of functions for grabbing/showing the permalink and guid value (as referenced from get_the_permalink() Documentation

also its worth noting that get_the_ID() returned the currently viewed page id NOT the iterated post id

also this is all contained within a shortcode function.

any help is greatly appreciated :)

Answer 1

I'm actually surprised that your code is working. There are several typos in it that should be throwing fatal errors.

global $post;
$args = array(
    'posts_per_page'   => -1,
    'post_type'        => 'post',
);
$the_query = new WP_Query( $args );

if ( $the_query->have_posts() ) :
    while ( $the_query->have_posts() ) : ?>
       <?php $the_query->the_post(); 
       $id = get_the_ID(); ?>
        <div class="row">
            <div class="col-md-6">
                <div class="card">
                    <h4><?php echo get_the_title( $id ); ?></h4>
                    <p><?php echo get_the_excerpt( $id ); ?></p>
                    <?php echo get_the_permalink( $id ); ?>

                    <a href="<?php echo get_the_permalink( $id ); ?>">Read More</a>
                </div>
            </div>
        </div>
    <?php  endwhile;
else :
    echo wpautop( 'Sorry, no posts were found' );
endif;

You mentioned that get_the_ID(); function works fine. So, what you can do is to manually feed the permalink function with the ID, something that I've done in my answer.

Also, you have a couple of missing semicolons, which I've corrected in the answer.

As a side note, ever use short PHP tags <?. They are deprecated, and on my system they even throw a fatal error. Always use full <?php tags.