First Custom Post Custom Fields Empty After New Custom Post

Question

I am working on a theme which contains a custom post type with custom fields.

Everything is working perfectly except the when a new custom post is added, the custom fields for the first custom post and first one only are wiped.

function save_details(){  
    global $post;  
    update_post_meta($post->ID, "testimonyname", $_POST["testimonyname"]);
}  
add_action('save_post', 'save_details'); 

This is what i am using to save the custom field data

Answer 1

First of all, save_post has an argument $post_id, so there's no need to global $post. In some cases, $post might not actually be set (anymore) when you do this, which is probably why it breaks. Second, you should probably check whether you're storing a revision or not (see below). So your code should look like this:

function save_details( $post_id ){  
    if ( wp_is_post_revision( $post_id ) )
        $post_id = wp_is_post_revision( $post_id );

    update_post_meta( $post_id, "testimonyname", $_POST["testimonyname"] );
}  
add_action('save_post', 'save_details', 10, 1); 

Answer 2

the problem was worse than I thought.

Here is the solution: Add New Post (Custom Post Type) Deletes 1 Post's Custom Meta Data

Answer 3

The above answer by Joost didn't work for me. Instead I found changing the action from save_post to post_updated solved my problem.