Re-Use existing functions
If you can: Use wordpress functions. Only replace them with custom php functions if you got no other possibility. This way you can use "log depracated notices" to easily keep an eye on functions that should be replaced. On the other hand users got the documentation in the codex and can take a look at what the plugin does even if they are no php heros.
