Specific coditional usage [closed]

Question

I have some trouble making work a conditional inside a Function.

check this out:

I'm using this function:

function get_spec_1(){
  $desc1 = get_post_meta( get_the_ID(), 'eco_mb_tp_1', true!= ""  );

  if(!empty ($desc1)){
    foreach ( $desc1 as $d1 ){
      $code = "
      <dl>
      <dt class='bullet6-top'>General</dt>
      <dd>
      <ul>
      <li>$d1</li>
      </ul>
      </dd>
      </dl>
      ";
      echo $code;
    }

  }
}

But this function causes this:

<dl>
    <dt class='bullet6-top'>Generales</dt>
    <dd>
    <ul>
    <li>$metabox_cloned_value_1</li>
    </ul>
    </dd>
</dl>

<dl>
    <dt class='bullet6-top'>Generales</dt>
    <dd>
    <ul>
    <li>$metabox_cloned_value_2</li>
    </ul>
    </dd>
</dl>

But what I'm trying to achieve is this:

<dl>
    <dt class='bullet6-top'>Generales</dt>
    <dd>
    <ul>
<li>$metabox_cloned_value_1</li>
<li>$metabox_cloned_value_2</li>
    </ul>
    </dd>
</dl>

And if there is no existing data.

then the entire <dl> will not show.

How can I obtain this result?

thanks

Answer 1

Here you go. Because the DL, DT, DD, and UL are all within the foreach loop, that is why they are being duplicated. Here is the proper code:

function get_spec_1(){
  $desc1 = get_post_meta( get_the_ID(), 'eco_mb_tp_1', true );

  if( !empty( $desc1 ) ){
    // Open the stuff
    $code = "
      <dl>
      <dt class='bullet6-top'>General</dt>
      <dd>
      <ul>";
    // Loop through the items once inside the ul
    foreach ( $desc1 as $d1 ){
      code .="<li>$d1</li>";
    }
    // Close the stuff
    code.="
      </ul>
      </dd>
      </dl>
      ";
    echo $code;
  }
}