Pass fileurl parameter into shortcode from Advanced Custom Fields

Question

I'm trying to create a custom shortcode that uses another shortcode for a couple audio players on a Grid displaying a custom post type using Visual Composer.

The audio player that I would like to use is the Compact Audio Player plugin which uses a shortcode of [sc_embed_player fileurl="URL OF THE MP3 FILE"].

What I want to do is create 2 custom shortcodes that inject the correct mp3 url into the fileurl=" " path when the grid loads. I'm using advanced custom fields and the code that I am using for one shortcode in my functions.php now is (I plan on duplicating when I can get this one to work for the other shortcode):

function get_generic_demo() {
$demo = get_field( 'generic_demo');
echo do_shortcode('[sc_embed_player fileurl="'.$demo['url'].'"]');
}
add_shortcode( 'generic_demo', 'get_generic_demo');

However, it gives me an error saying I didn't input a valid url when the grid displays when my custom shortcode is entered.

I've tried both setting the return from ACF to file url and the array (as used above).

I've also tried:

$demo = get_field( 'generic_demo', $post->ID);

Any help would be much appreciated

Answer 1

Do not use echo in your shortcode. Use return instead.

function get_generic_demo() {
    //Get the field's value
    $demo = get_field( 'generic_demo');
    //Save the URL into a variable
    $url = $demo['url'];
    // Pass it to the other shortcode and return its value
    return do_shortcode('[sc_embed_player fileurl="'.$url.'"]');
}
add_shortcode( 'generic_demo', 'get_generic_demo');

Also make sure your fields contain the proper URL format. Dump the variable by using var_dump to verify it. This is most likely where your problem is coming from.

Answer 2

I'm not 100% positive if this will fix it, but try pulling the global post variable into your shortcode declaration function:

function get_generic_demo() {
    global $post;
    //Get the field's value
    $demo = get_field('generic_demo');
    //Save the URL into a variable
    $url = $demo['url'];
    // Pass it to the other shortcode and return its value
    return do_shortcode('[sc_embed_player fileurl="'.$url.'"]');
}
add_shortcode( 'generic_demo', 'get_generic_demo');

---

** RESPONSE EDIT - 2017-06-20 @ 11:45AM **

The issue appears to be that however Visual Composer is building the grid, the CPT IDs aren't being acknowledged. How is the rest of the data being set for each item entry (i.e. the title and description of each item)? Are you manually entering it into the grid or is it being automatically generated?