Rewrite Rules not redirecting rewrite

Question

I have the following custom rewrite rules.

add_action( 'init', 'corse_rewrite_rules', 0 );
function corse_rewrite_rules( ) {

    add_rewrite_rule('listings/make/([^/]*)/page/?([0-9]{1,})/?$', 'index.php?post_type=product&product_make_model=$matches[1]&paged=$matches[2]', 'top');

    add_rewrite_rule('listings/make/([^/]*)/?$', 'index.php?post_type=product&product_make_model=$matches[1]', 'top');

}

Which should take a URL like this :

/product_make_model/stuff/

to :

/listings/make/stuff/

The issue in hand is that although the Rewrite is working and the new URL is accessible, its not redirecting the old URL to the new one.

If I also add an SEO plugin such as YOAST the canonical URL is listed as the the old URL confirming that there is something wrong.

Could someone shed some light as to what im doing wrong ?

Answer 1

Ok managed to figure this out, instead of adding action for a rewrite. Because what I was wanting to rewrite was a taxonomy i should have been using something like this :

'rewrite' => array('slug' => 'listings/make', 'product_make_model' => false)

When registering the taxonomy, which basically rewrites the slug as the taxomomy is created/registered.

Works perfectly.