Timeline for Sanitizing output that contains quotes?
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Aug 25, 2016 at 12:48 | comment | added | birgire | I see, good luck with the revision and cleanup ;-) @dingo_d | |
| Aug 25, 2016 at 11:39 | comment | added | dingo_d | Well to be quite honest I am doing a code revision and it was added this way. If I'm not mistaken there was an inline css added by the customizer, and I think that the custom theme option didn't work unless it was in the element directly. I would also like to minimize the unnecessary inline styles if possible... | |
| Aug 25, 2016 at 11:32 | comment | added | birgire |
I think empty style attributes like <div style=""></div> are valid, but one can prevent adding such an empty attribute with an if-check. But I think we should try to avoid "polluting" the HTML tags directly with such style attributes, if possible. It's usually harder to maintain and less flexible. @dingo_d
|
|
| Aug 25, 2016 at 11:16 | comment | added | birgire |
I'm just wondering why you need the hardcoded style attribute in the HTML tags, if you define the custom/dynamic CSS within <style> e.g. via wp_add_inline_style() ? @dingo_d
|
|
| Aug 25, 2016 at 11:11 | comment | added | dingo_d | This could work, sure, but I think I'd have a lot of modification to do. The theme settings have settings for breadcrumbs, widget areas, footer etc. plus a whole lot of custom logic inside. Having an empty style inline is still a valid HTML, no? | |
| Aug 25, 2016 at 11:06 | history | answered | birgire | CC BY-SA 3.0 |