PHP displaying wrong custom taxonomy images

Question

I'm using the Taxonomy Images plugin to try to pull in the category images for custom categories on a page that displays all the categories my site has. For some reason, this code outputs the correct names and descriptions, but will only show one category image.

I'd like the images to do what the other category features do, populate with the appropriate data for each category and display all the categories on the page. If I use echo wp_get_attachment_image( $imgs[$id], 'thumbnail' ); it publishes all of the images, but if I change that from echo to make it a variable, it only displays one image.

$imgs = get_option( 'taxonomy_image_plugin' );
$categories = get_terms('portfolio_category', array('orderby' => 'id', 'hide_empty' => 0));
foreach ( $categories as $category ) {
    $id = $category->term_id;
    $img = wp_get_attachment_image( $imgs[$id], 'thumbnail' );
}
    for($i=0; $i<count($categories); $i++)
     {
     echo('<h2>'.$categories[$i]->name.'</h2>');
     echo($img);
     echo('<p>'.$categories[$i]->description.'</p>');
}

I guess that I'm just confused as how to add a counter like [$i] so that this code outputs the correct category images. Any help would be much appreciated.

Answer 1

I think (at least part of) the problem is that you've got a nested loop where you don't really need one.

The output of get_terms() is an array of objects. So $categories should be an array of objects.

You loop through this array of objects here:

foreach ( $categories as $category ) {
    $id = $category->term_id;
    $img = wp_get_attachment_image( $imgs[$id], 'thumbnail' );
}

The problem is that you close that loop, and then loop through $categories a second time:

for($i=0; $i<count($categories); $i++)
     {
     echo('<h2>'.$categories[$i]->name.'</h2>');
     echo($img);
     echo('<p>'.$categories[$i]->description.'</p>');
}

The problem there, though, is that $id and $img will retain their value based on the last object in $categories.

I would recommend getting rid of the second loop, and doing everything in your original foreach loop:

foreach ( $categories as $category ) {
    // Set ID and IMG
    $id = $category->term_id;
    $img = wp_get_attachment_image( $imgs[$id], 'thumbnail' );

    // Output markup
     echo('<h2>'.$category->name.'</h2>');
     echo($img);
     echo('<p>'.$category->description.'</p>');
}

That should fix the issues with out-of-sync looping, though I'm not entirely certain about $img, since I'm not familiar with the Plugin you're using and don't know how it saves its option to the database.

Answer 2

Chip was on the right path, but closing the first loop would only publish one category instead of every category. What I ended up doing was closing the first loop and calling the ID and the img inside the second loop.

$imgs = get_option( 'taxonomy_image_plugin' );
$categories = get_terms('portfolio_category', array('orderby' => 'id', 'hide_empty' => 0));
for($i=0; $i<count($categories); $i++)
    {
    $id=$categories[$i]->term_id;
    $img=wp_get_attachment_image($imgs[$id], 'thumbnail');
        echo('<h2>'.$categories[$i]->name.'</h2>');
        echo($img);
        echo('<p>'.$categories[$i]->description.'</p>');
    }