Pagination in custom query not working

Question

hi im trying to output pagination without any success. below is my code in a page-products.php template

<?php $products_query = new WP_Query(array(
    'post_type' => 'product',
    'posts_per_page' => 4,
    'paged' => (get_query_var('page') ? get_query_var('page') : 1),
));?>

<?php if($products_query->have_posts()) : while($products_query->have_posts()) : $products_query->the_post();?>

<?php the_content; ?>

<?php endwhile; ?>
<?php posts_nav_link();?>
<?php endif; ?>

i cant seem to output my pagination links. can anybody help spot whats wrong?

Answer 1

I believe the query var that you are retrieving should be paged and not page. See the codex and adjust your query to the following:

$products_query = new WP_Query(array(
    'post_type' => 'product',
    'posts_per_page' => 4,
    'paged' => (get_query_var('paged') ? get_query_var('paged') : 1),
));

However, if this is an archive for your product post type why not use archive-product.php and let WP handle the query and pagination automatically? See template hierarchy.