Take the 2-minute tour ×
WordPress Development Stack Exchange is a question and answer site for WordPress developers and administrators. It's 100% free, no registration required.

I have a custom post type 'events', to which I have associated a custom taxonomy 'calendar'. The calendar has 12 fixed terms, for each month of the year ( 'august', 'october', 'november, etc.).

I'm in the process to make the archive page for the 'events' post type. I was thinking to display 12 different lists of max 10 posts each, for each month of the year == terms in the 'calendar' taxonomy.

Since this would be an archive page, Wordpress would have already queried the database for 'events' post type. I was about to use query_posts to alter the main query, but I suddenly wondered if there was a better way to make a more optimized use of the default query. query_posts would essentially throw away the main query and with 12 lists to generate, it would cause more hits to the database.

Which is the best practice for this case?

Would you just run 12 instances of query_posts, one for each list, or you'd rather do something else, ie with pre_get_posts or something?

thanks for sharing your ideas

share|improve this question
add comment

2 Answers

up vote 2 down vote accepted

Don't use query_posts(). Don't modify the main loop query from within the template.

You may be able to get a single query to provide what you need (e.g. by filtering pre_get_posts and groupby), but more than likely, you will need to iterate 12 custom loops using WP_Query(). Perhaps something like this:

// Get all the months
$months = get_terms( $calendar );

// Set up the base query args
$events_query_args = array(
    'post_type' => 'events',
    'post_per_page' => 10,
    'tax_query' => array(
        array(
            'taxonomy' => 'calendar',
            'field' => 'slug',
            'terms' => ''
        )
    )
);

// Loop through the months, and
// output a custom query and loop
// for each
foreach ( $months as $month ) {

    // Add $month to the query args
    $events_query_args['tax_query']['terms'] = $month['slug'];

    // Build the query
    $events_query = new WP_Query( $events_query_args );

    // Open the query loop
    if ( $events_query->have_posts() ) : while ( $events_query->have_posts() ) : $events_query->the_post();

        // YOUR LOOP CODE GOES HERE

    // Close the loop
    endwhile; endif;

    // Clean up
    $events_query = null;
    wp_reset_postdata()
}

You'll have to add the actual Loop output markup, of course.

share|improve this answer
add comment

I can not come up with any reason why you wouldn't want to query the database 12 times if what you need is 12 individual sets of posts except when you are running a site like CNN or NYT where big numbers matter. You could run a single query for all posts for that taxonomy and use PHP to split them up by category but in the end that doesn't sound like a great idea since that's just not what PHP is for.

If you are worried about ressources: use the transients API to cache your query. (Example)

If you are worried about altering the main loop: just call wp_reset_query after you are done.

share|improve this answer
    
Well yeah you right on one hand, I know that I "could" query twelve times just to get some list. On the other hand I'm always after means to improve and optimize my work on Worpdress, no matter what. So if there's a better way to do something which I'm not totally sure of, I'll inform myself or ask around. There's always something to learn, I guess. I will give a try to Chip's advice and in future learn more about caching queries. Thanks :) –  Fulvio Sep 3 '12 at 14:50
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.