Include different loop templates in search query

Question

I have differnet Custom Post Types in my blog.
I also have custom templates for each of them like loop-{$cpt-name}.php
I would like to include different cpt templates dynamically in search results based on what custom post type is post at the moment in the loop. I am trying to do it like this ( search.php ):

<?php
            while ( have_posts() ) : the_post(); 
                if ( get_post_type ( $post->ID ) == 'teams' ) {
                    get_template_part( 'loop', 'teams' );
                } elseif ( get_post_type ( $post->ID ) == 'players' )  {
                    get_template_part( 'loop', 'players' );
                } else {
                    get_template_part( 'loop', 'search' );
                }
            endwhile;
            ?>

However, the problem is that when I am trying to do it like so, I have infinitive loop in a query. Because in search.php file I check the post type in the while loop and include the template where I also have while statement ( I need to have it there ). Example of my CPT template ( beginning ):

<?php 
/**
 * The loop that displays teams
 *
 */
if ( have_posts() ) while ( have_posts() ) : the_post(); 

I came up with the idea to make additional query for each found post in the loop, like so:

while ( have_posts() ) : the_post(); 
    if ( get_post_type ( $post->ID ) == 'teams' ) {
            query_posts('p='.$post->ID);
            get_template_part( 'loop', 'teams' );
            wp_reset_query();

But I suppose that would slow down the search in times. ( have not tested yet)
Any suggestions will be appreciated.

Answer 1

I would recommend using content-{posttype}.php method, where you only have HTML markup, template tags for posts or custom post types and leave loops outside of those files. See Twenty Eleven for more detailed example.

After this change you can easily modify search.php and include specific content markup based on post type.

if ( have_posts() ) : 
    while ( have_posts() ) : the_post();    

    /**
     * Would include CPT content template (content-teams.php) if it exists
     * or content.php otherwise.
     */
    get_template_part( 'content', get_post_type( $post ) ); 

    endwhile;
endif;

Answer 2

You're definitely better off only doing one query, but it will require a little re-architecting of your custom post type loops. Basically, you would move the presentation code out of the loops, into new files (which we'll call "partials"). Instead of loop-{$cpt-name}.php, you'd have a file partial-{$cpt-name}.php.

Instead of checking the post type from search.php, you'll check it in loop-search.php where you'll include the appropriate partials if they exist, like so:

<?php
while ( have_posts() ) : the_post(); 
 $cpt = $post->post_type; 
 $partial = "partial-{$cpt}.php";
 if ( locate_template( $partial )
    {
      include( locate_template( $partial ) );
    }
  else
    {
      ?>
      <div>Default Search loop output here for non-CPT posts</div>
      <?php
    }
endwhile;
?>

You would do the same thing in your regular loop, rather than using separate loops for each custom post type. If you want to keep using separate loops, you'd import the partials in those CPT loops instead of specifying the presentation code.