Take the 2-minute tour ×
WordPress Development Stack Exchange is a question and answer site for WordPress developers and administrators. It's 100% free, no registration required.

I'm creating som custom templates in Wordpress and I'm passing some data in the URL's.

Currently my URL looks like this: http://www.mysite.com/designers/?id=43&name=designer+name

The URL contains designer ID and designer name.

I would really like to use this: http://www.mysite.com/designers/designer+name/

My permalink structure is set to /%category%/%postname%/

My .htaccess file looks like this:

# BEGIN WordPress
<IfModule mod_rewrite.c>
RewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php [L]
</IfModule>
# END WordPress

I've looked at http://codex.wordpress.org/Using_Permalinks, but not become any wiser.

I got two questions:

  1. Is there any point in changing the above URL regarding SEO
  2. How can I get the "pretty" URL?

UPDATE
I'm adding some more info for clarification.

  • I'm developing the site myself
  • The template is 100% custom template
  • Based on info from $_GET, I load data from my custom DB table and display this on page
  • My site has an avarage of between 3-400 unique visitors per day. At peak I have 2000 unique visitors per day.
  • I'm developing an online fashion magazine
  • My URL is currently being created like this:

    Url = get_permalink().'?bid='.$brand->id.'&name='.$brand->name;

  • I've used similar method here:
    http://storelocator.no/search/?brandID=4673&storeID=0&brand=Moods+of+Norway

Using Custom Post Type was an option I considered, but I needed my own table structurem because designers / brands are linked up against galleries (and more links to other tables to come). So saving brands data in WP POST table was not going to work.

So I need to know this:

  • What do I need to do with my Permalink structure?
  • What do I need to do with my .htaccess file?
share|improve this question
    
@Steven: Is this a custom post type with a rewrite setting? (Please add the register_post_type code if it is.) If you create a regular blog post, what is its address? –  Jan Fabry Nov 2 '10 at 8:54
    
@Steve - Ah, I see you did ask over here. Great! –  MikeSchinkel Nov 2 '10 at 9:03
    
This is not a custom post type. It's just a template that retrieves data from a DB based on info passed by $_GET(). –  Steven Nov 2 '10 at 9:22
    
@Steven: OK, so you want to know how to get URL's like /designer/designer_A, /designer/designer_B, ... handled by the same template, that can then access the designer name from the URL easily? This is then a question about adding your own rewrite rule? –  Jan Fabry Nov 2 '10 at 10:28
1  
@Steve - I strongly recommend you reconsider Custom Post Types. You are trying to reinvent the wheel and a really got set of wheels already exist in WordPress. You say you can't use CPTs; will you consider maybe asking another question here on WordPress Answers that asks how to get around the roadblock you perceive with CPTs? I'll bet you'll be surprised how easy the solution will be. Create both a "Brand" CPT and a "Gallery" CPT then link them together (there are several ways to do that...) –  MikeSchinkel Nov 3 '10 at 3:10
show 3 more comments

3 Answers

up vote 4 down vote accepted

I don't know (or didn't know) much about the rewrite rules myself (but it seems nobody does), but based on some other answers here, I got this to work. We add a new rewrite rule that matches designers/designer_name/. We "flush" the rewrite rules so they get saved to the database, but make sure to do this only once, since it is an expensive operation. Now, we set up a pattern that will match our page and save the extra part in the designer_name query variable. Since WordPress does not know it must look at this variable, we hook into the query_vars filter and tell it to look at that too.

Now, in the page-designers.php theme file, we can do get_query_var('designer_name') and it will give you the designer name. If you want extra stuff like paging (designer/designer_name/page/2), you need to add an extra rewrite rule for that (or feeds, or whatever that starts with designer/designer_name). But the basic stuff should work.

<?php
/*
Plugin Name: WPA 3537
Plugin URI: http://wordpress.stackexchange.com/questions/3537/need-help-with-friendly-urls-in-wordpress
Description: Need help with friendly URL's in Wordpress
Version: 1.0
Author: Jan Fabry
*/

register_activation_hook(__FILE__, 'wpa3537_flush_rules');
function wpa3537_flush_rules()
{
    add_rewrite_rule('designers/([^/]+)', 'index.php?pagename=designers&designer_name=$matches[1]', 'top');
    flush_rewrite_rules(false);
}

add_filter('query_vars', 'wpa3537_query_vars');
function wpa3537_query_vars($query_vars)
{
    $query_vars[] = 'designer_name';
    return $query_vars;
}
share|improve this answer
3  
Yes, WordPress' URL rewriting is a black art. One must be careful when practicing lest one cross over to the dark side and be driven irreversibly insane. –  MikeSchinkel Nov 3 '10 at 3:20
1  
@Mike: I got intrigued by it (must be the Halloween time), and wrote a rewrite rule analyzer as a trace of my discoveries in rewrite-land. –  Jan Fabry Nov 3 '10 at 20:37
    
For full answer, se this thread: wordpress.stackexchange.com/questions/5413/… –  Steven Dec 16 '10 at 14:45
add comment

Hi @Steven:

First I have a question: How are you getting URLs that look like the following?

http://www.mysite.com/designers/?id=43&name=designer+name

Those are not standard URLs for WordPress; is that the way you envision is should work, or does your site actually work that way? And if so, how did those URLs come to be? Is it a highly customized site? Who customized it; you, or someone else?

About .htaccess

That said, we'll start with .htaccess to get that out of the way. Yours is identical to practically every other WordPress installation's .htaccess file except for installs that 1.) serve off a URL subdirectory (and then the difference is trivial), 2.) have had people who don't understand how WordPress routes URLs mucking around them and/or 3.) except for those rare advanced installs that actually do need .htaccess mucking (and if you don't know why you would need to do it chance are almost 100% that you don't.)

About Leading Categories in WordPress URLs

Next, your desired URL format with category name in the first path segment is pattern that the WordPress community frowns upon for performance reasons, see this:

Basically the problem is if you have more than a handful for "Pages" (i.e. $post->post_type=='page') then WordPress will compare every URL for every page load against the URL for every Page and that can slow down your system. That said, if you only have a handful of Pages and you don't have a high-traffic site, it's my opinion not to sweat it.

Screenshot showing what Pages in WordPress are, i.e. $post_type=='page'

Now on to your questions.

1.) Is there any point in changing the above URL regarding SEO

Yes. Cleaning up the URL improves your keyword densities. That said, in my opinion there's a lot more to SEO than just what the search engine sees and making your URLs friendlier will give people more confidence in them and make it more likely they will link to your site in blogs and share your links on Twitter, in Facebook and elsewhere. That creates two benefits; more links the search engines see and more exposure from the sharing.

Personally I like to think of it as how one dresses; if you are really messy then people are going to have a lower subconscious opinion of you than if you are meticulous. I think the same is true with URLs; if you have clean, user friendly URLs your house appears to be in order; if you have sloppy URLs your site will just not "feel" the same, again IMO. (Nasty URLs are one reason I loathe using LinkedIn. I think they'd have been more successful had they paid attention to the URLs like Twitter did, for example.)

2.) How can I get the "pretty" URL?

I think this article and/or this page on Codex should be able to help?

Basically you need to set your Permalinks template and then save them. You might have to use FTP to change the permission settings on .htaccess before WordPress can save them for you. Hopefully this screenshot will be enough to illustrate what you need to do:

Screenshot showing how to Set Permalinks in WordPress

Let me know if this answers your question and if not where you are stuck.

Other Permalink Answers

In addition there are lots of other answers to questions about Permalinks in WordPress here at WordPress Answers; some of these might be of help to you too, in no particular order:

share|improve this answer
    
Thanks for the detailed answer. See my updated question for your answers. I know how to use normal permalink structure. But I don't know how to change it to suit my needs. –  Steven Nov 2 '10 at 12:52
    
PS. I'm not really a hardcore programmer, more like a front end developer. So at this level of logic, some stuff might be beyond my skills.... but I learn every day :) –  Steven Nov 2 '10 at 12:58
    
@MikeSchinkel: Looking at an answer here: stackoverflow.com/questions/4073599/…, I'm ot sure wher to start. Do you have any suggestions to push me in the right direction? –  Steven Nov 2 '10 at 21:01
    
@Steve - Yeah, his answer is not so good. As I said above I really think "Ur Doin it Rong" (hope you can enjoy the lolcat humor :) Custom Post Types is almost certainly the way to go; your current structure is trying to fight with WordPress to get it to behave differently when you could just accept CPTs and get so much functionality for free. Please document in another question what you feel CPTs are missing and I'll bet we'll be able to easily solve that one for you. –  MikeSchinkel Nov 3 '10 at 3:16
    
I'll answer the Q about CPT later. I've worked all nightto get norwegianfashion.no up and running. A bit tired now. But here you can see it in action (/designers/). I have to read up on CPT - and maybe I'll usit in version 2.0 :) –  Steven Nov 3 '10 at 6:47
show 1 more comment

I did all Jan Fabry wrote, but when I call:

http://www.mysite.com/customPostTypeSlug/page/id

Wordpress redirect (301) me to:

http://www.mysite.com/customPostTypeSlug/page

My rule is (called by an "init" action):

add_rewrite_rule(
        'customPostTypeSlug/page/([^/]+)/?' ,
        'index.php?customPostTypeSlug=page&id=$matches[1]',
        'top'
    );

Then I flush it.

I change permalink from %category%/%postname% to %postname% and seems to work.

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.